Fix print jobs incorrectly marked as finished even though some layers were not #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plete Without this, a job progress can happen to be 1 even when 1 out of 20 layers is not finished due to rounding errors.
Also modified assertions in other test since `expect.anyContaining({})`
will match `null`!
jahow
force-pushed
the
fix-20-layers-limit
branch
from
43c087d
to
2f240b5
Compare
LHBruneton-C2C
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was due to an oversight in progress rounding logic. Added a failing test fixed by this change.
Also added unrelated unit tests for the new GeoJSON layer that was added in #42 and #44.