Skip to content

Commit

Permalink
Remove leftover coveralls config in karma
Browse files Browse the repository at this point in the history
  • Loading branch information
fredj committed Mar 1, 2019
1 parent 8085e9b commit 15b2340
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 20 deletions.
18 changes: 1 addition & 17 deletions karma-conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ module.exports = function(config) {
// test results reporter to use
// possible values: 'dots', 'progress'
// available reporters: https://npmjs.org/browse/keyword/karma-reporter
reporters: isDebug ? ['progress', 'coverage-istanbul'] : ['coverage-istanbul'],
reporters:['progress'],

// web server port
port: 9876,
Expand Down Expand Up @@ -83,21 +83,5 @@ module.exports = function(config) {
// Continuous Integration mode
// if true, Karma captures browsers, runs the tests and exits
singleRun: false,

// any of these options are valid: https://github.com/istanbuljs/istanbuljs/blob/aae256fb8b9a3d19414dcf069c592e88712c32c6/packages/istanbul-api/lib/config.js#L33-L39
coverageIstanbulReporter: {

// reports can be any that are listed here: https://github.com/istanbuljs/istanbuljs/tree/aae256fb8b9a3d19414dcf069c592e88712c32c6/packages/istanbul-reports/lib
reports: isDebug ? ['lcovonly', 'text-summary', 'html'] : ['lcovonly', 'text-summary'],

// base output directory. If you include %browser% in the path it will be replaced with the karma browser name
dir: path.resolve(__dirname, '.build/coverage'),

// if using webpack and pre-loaders, work around webpack breaking the source path
fixWebpackSourcePaths: true,

// stop istanbul outputting messages like `File [${filename}] ignored, nothing could be mapped`
skipFilesWithNoCoverage: true
}
});
};
3 changes: 0 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@
"fs-extra": "7.0.1",
"html-webpack-include-assets-plugin": "1.0.6",
"html-webpack-plugin": "3.2.0",
"istanbul-instrumenter-loader": "3.0.1",
"jasmine-core": "3.3.0",
"jquery": "3.3.1",
"jquery-datetimepicker": "2.5.21",
Expand All @@ -99,8 +98,6 @@
"jsts": "2.0.3",
"karma": "4.0.1",
"karma-chrome-launcher": "2.2.0",
"karma-coverage": "1.1.2",
"karma-coverage-istanbul-reporter": "2.0.5",
"karma-jasmine": "2.0.1",
"karma-sourcemap-loader": "0.3.7",
"karma-webpack": "3.0.5",
Expand Down

0 comments on commit 15b2340

Please sign in to comment.