Apply reviewer's comments

camptocamp · Feb 7, 2019 · f0330e0 · f0330e0
1 parent c6365b6
commit f0330e0
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/contribs/gmf/src/controllers/AbstractAppController.js b/contribs/gmf/src/controllers/AbstractAppController.js
@@ -40,7 +40,7 @@ import {findThemeByName} from 'gmf/theme/Themes.js';
  * @property {import("ol/style/Style.js").default} [positionFeatureStyle]
  * @property {import("ol/style/Style.js").default} [accuracyFeatureStyle]
  * @property {number} [geolocationZoom]
- * @property {boolean|undefined} [autorotate]
+ * @property {boolean} [autorotate]
  * @property {olx.ViewOptions} [mapViewConfig]
  * @property {import("ol/Collection.js").default.<import('ol/control/Control.js').default>|Array.<import('ol/control/Control.js').default>} [mapControls]
  * @property {import("ol/Collection.js").default.<import('"ol/interaction/Interaction.js').default>|Array.<import('ol/interaction/Interaction.js').default>} [mapInteractions]

diff --git a/contribs/gmf/src/search/component.js b/contribs/gmf/src/search/component.js
@@ -40,7 +40,7 @@ import {appendParams as olUriAppendParams} from 'ol/uri.js';
  * this dataset. See: https://github.com/twitter/typeahead.js/blob/master/
  * @property {string} url URL of the search service. Must contain a '%QUERY' term that will be
  * replaced by the input string.
- * @property {string|undefined} datasetTitle
+ * @property {string} [datasetTitle]
  * }}
  */
 

diff --git a/contribs/gmf/src/themes.js b/contribs/gmf/src/themes.js
@@ -148,11 +148,11 @@
  * @property {string|undefined} geometryName Geometry name.
  * @property {string} imageType 'image/png' or 'image/jpeg'.
  * @property {boolean} isSingleTile
- * @property {string|undefined} namespace Namespace
+ * @property {string} [namespace] Namespace
  * @property {string} type 'mapserver', 'qgisserver', 'geoserver' or 'other'.
  * @property {string} url
  * @property {string} urlWfs The WFS URL.
- * @property {string|undefined} wfsFeatureNS WFS feature namespace
+ * @property {string} [wfsFeatureNS] WFS feature namespace
  * @property {boolean} wfsSupport
  */
 

diff --git a/src/filter/RuleHelper.js b/src/filter/RuleHelper.js
@@ -37,7 +37,7 @@ import moment from 'moment';
  * @property {!Array.<import('ngeo/rule/Rule.js').default>} [filterRules] An alternative list of filter rules to use instead of those that are defined
  * within the data source. Useful when one wants to get the data of a given
  * filter without applying it to the data source.
- * @property {string|undefined} [projCode] Projection code.
+ * @property {string} [projCode] Projection code.
  * @property {string} [srsName] The SRS name used with the spatial filters created by the method.
  */