Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmf.BackgroundlayerselectorController is broken #1791

Closed
tsauerwein opened this issue Sep 2, 2016 · 2 comments · Fixed by #1807
Closed

gmf.BackgroundlayerselectorController is broken #1791

tsauerwein opened this issue Sep 2, 2016 · 2 comments · Fixed by #1807
Assignees
Milestone

Comments

@tsauerwein
Copy link

tsauerwein commented Sep 2, 2016

Locally I get the following error when trying to open all three applications (mobile, desktop, desktop_alt):

AssertionError: Assertion failed: The dimensions object is required
    at new goog.asserts.AssertionError (http://localhost:3000/@/home/tsauerwein/projects/ngeo/node_modules/closure-…9481f1e57fbba986e2304ac80d4173f94c9c/closure/goog/asserts/asserts.js:62:20)
    at Object.goog.asserts.doAssertFailure_ (http://localhost:3000/@/home/tsauerwein/projects/ngeo/node_modules/closure-…481f1e57fbba986e2304ac80d4173f94c9c/closure/goog/asserts/asserts.js:121:11)
    at Object.goog.asserts.assert [as assert] (http://localhost:3000/@/home/tsauerwein/projects/ngeo/node_modules/closure-…481f1e57fbba986e2304ac80d4173f94c9c/closure/goog/asserts/asserts.js:151:18)
    at new gmf.BackgroundlayerselectorController (http://localhost:3000/@/home/tsauerwein/projects/ngeo/contribs/gmf/src/directives/backgroundlayerselector.js:129:16)
    at Object.invoke (http://localhost:3000/node_modules/angular/angular.js:4718:19)
    at $controllerInit (http://localhost:3000/node_modules/angular/angular.js:10354:34)
    at nodeLinkFn (http://localhost:3000/node_modules/angular/angular.js:9263:34)
    at http://localhost:3000/node_modules/angular/angular.js:9673:13
    at processQueue (http://localhost:3000/node_modules/angular/angular.js:16383:28)
    at http://localhost:3000/node_modules/angular/angular.js:16399:27

On the online demo, I only see this error for mobile and desktop.

@sbrunner sbrunner added this to the 2.1 milestone Sep 2, 2016
@adube
Copy link
Contributor

adube commented Sep 6, 2016

Introduced in #1701. I'll read about it and figure out what's missing.

@gberaudo
Copy link
Member

gberaudo commented Sep 6, 2016

You need to pass the dimensions object from the main controller to the directive.

adube added a commit to adube/ngeo that referenced this issue Sep 6, 2016
fredj added a commit that referenced this issue Sep 7, 2016
Fix #1791 - Background layer selector directive must use dimensions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants