Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Can customize feature style #869

Closed
ger-benjamin opened this issue Mar 14, 2016 · 21 comments
Closed

Search - Can customize feature style #869

ger-benjamin opened this issue Mar 14, 2016 · 21 comments
Assignees
Milestone

Comments

@ger-benjamin
Copy link
Member

Currently, we display searched features with the default overlay style (blue border, blue/transparent fill). In CGXP we can choose the default style and we have a color picker.

Remaining questions for this issue:

  • Should we create a colorpicker component ?
  • Should we be able to configure a specific style for coordinates search (like a cross instead of the default circle) ?
@sbrunner
Copy link
Member

Yes two times

@fgravin
Copy link
Member

fgravin commented Mar 21, 2016

Yes two times

means yes for both ?

@ybolognini
Copy link
Member

Should we create a colorpicker component ?

Yes

Should we be able to configure a specific style for coordinates search (like a cross instead of the default circle) ?

Yes

Yes two times
means yes for both ?

Yes

@fgravin
Copy link
Member

fgravin commented Mar 22, 2016

I've created a color picker directive.
#928

@fgravin
Copy link
Member

fgravin commented Mar 22, 2016

Where are the specs ?
Seems the work of @ger-benjamin allow to have different colors for each group of the search, was it wanted ?

So, when the user choose a color from the color picker, does it overload all group styles ?

Can the user manually set a color for the cross if coordinates as well ?

@ger-benjamin
Copy link
Member Author

Perhaps that I've went too far. It seems that allowing to have different colors for each group reflet any request (even if I like it).

The original request is to reproduce what are currently existing in GMF 1.6 I've identified:

  • Users can set a default color.
  • Users can choose a color on a colorpicker (on the fly, at any moment)
  • Users can set the style for the default cross on coordinates search.

Perhaps I've missed something...

@fgravin
Copy link
Member

fgravin commented Mar 22, 2016

Users can set a default color
Users can set the style for the default cross on coordinates search

By user you mean the platform administrator (with custom params) ?

@fgravin
Copy link
Member

fgravin commented Mar 22, 2016

Could we have more info about the spec @sbrunner @ybolognini ?

Shall we keep the possibility to have one style per search group ???

@ger-benjamin
Copy link
Member Author

  • Admin can set a default color.
  • Any users can choose a color on a colorpicker (on the fly, at any moment)
  • Admin can set the style for the default cross on coordinates search.

@sbrunner
Copy link
Member

Shall we keep the possibility to have one style per search group ???

no

+1 @ger-benjamin

@pgiraud
Copy link
Contributor

pgiraud commented Apr 5, 2016

Design specs to be discussed in WIKI page https://github.com/camptocamp/c2cgeoportal/wiki/Specs-%23869---Color-of-search-result

@ybolognini ybolognini added Backlog and removed Ongoing labels Apr 7, 2016
@ybolognini
Copy link
Member

Specifications are now ready for validation!

ping @rbovard @gnerred @svarim @vvmalbre @mriedo @gsollberger @svavoi @cedricmoullet @kalbermattenm

@svavoi
Copy link

svavoi commented Apr 8, 2016

Thanks for the specifications "color of search result". In general it's fine for me.
But I have two questions regarding the coordinate search:

  • At the moment the marker of the coordinate search can not be deleted with the delete button of the search. Will this be possible in the future?
  • We think it would be nice to be able to change the color as well for the marker of the coordinate search. What is the opinion of the others?

@vvmalbre
Copy link

vvmalbre commented Apr 8, 2016

Thanks as well from our side for your proposition.

  • +1 @svavoi: deleting the marker of the coordinate search should be possible. Changing its color is "nice to have" but doesn't have very high priority.
  • Question: Is an area highlight always displayed with a slightly transparent fill? I think an area highlight without any fill would be good (is this configurable)?

@gnerred
Copy link

gnerred commented Apr 11, 2016

+1 @svavoi
The possibility to have an area without fill is a "nice to have" for us.

@rbovard
Copy link
Contributor

rbovard commented Apr 11, 2016

+1 @svavoi: deleting the marker of the coordinate search should be possible. Changing its color is "nice to have" but doesn't have very high priority.

+1

Question: Is an area highlight always displayed with a slightly transparent fill? I think an area highlight without any fill would be good (is this configurable)?

In 1.6 you can set it via vectorLayerConfig (see http://docs.camptocamp.net/cgxp/1.6/lib/plugins/FullTextSearch.html), I hope this will be still possible in 2.1.

In general, I think the possiblity for the user to change the color is not a high priority since the integrator can set the style via options...

@mriedo
Copy link

mriedo commented Apr 12, 2016

+1 @svavoi: deleting the marker of the coordinate search should be possible. Changing its color is "nice to have" but doesn't have very high priority.

+1

@ybolognini
Copy link
Member

@svavoi @vvmalbre @gnerred @rbovard @mriedo

Yes, deleting the coordinate marker like we can delete the search result highlight will be implemented.

Yes, we will have the possibility to choose the style of the highlight (similar to vectorLayerConfig).

Coordinate marker won't change color with search colorpicker. But marker style can be configured, symbol itself can be changed if needed

@rbovard
Copy link
Contributor

rbovard commented Apr 14, 2016

Ok, thanks!

@gsollberger
Copy link

ok for me.

@ger-benjamin ger-benjamin removed their assignment May 3, 2016
@ybolognini ybolognini added Ready and removed Backlog labels May 11, 2016
@fredj
Copy link
Member

fredj commented Jun 22, 2016

fixed with #1247

@fredj fredj closed this as completed Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.