New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a color picker directive #928
Conversation
Does the example need a map? |
'#3f48cc', '#a349a4'], | ||
['#b97a57', '#ffaec9', '#ffc90e', '#efe4b0', '#b5e61d', '#99d9ea', | ||
'#7092be', '#c8bfe7'], | ||
['#ffffff', '#f7f7f7', '#c3c3c3', '#000000'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's those default color, from where does come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Luxembourg project.
We can define one that fits geomapfish needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that the one in the example comes from the example itself, it is overloaded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't find where he is visible, In the redlining I have a colorpicker from the browser...
I see that it's overloaded in the example but I think that the default value should already be a good chose :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used in Luxembourg when <input type="color"
is not available, try with IE11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, thanks, that's looks not so bad :-)
Address my comments then it will be ready to merge for me. |
Do you have any idea when this could be merged ? I need it for the editing tools. |
I'll work a bit on it now. |
f347134
to
d745325
Compare
PR and example updated. |
The UI looks very good and is much nicer. |
Thanks @pgiraud, i admit it is wonderfull. |
Add a basic color picker.
Will be used in style form for example.
Example: http://fgravin.github.io/ngeo/colorpicker/examples/colorpicker.html
See https://github.com/camptocamp/c2cgeoportal/wiki/Spec-%231658-Measures-and-redlining