Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a color picker directive #928

Merged
merged 1 commit into from Mar 29, 2016
Merged

Conversation

fgravin
Copy link
Member

@fgravin fgravin commented Mar 22, 2016

@pgiraud
Copy link
Contributor

pgiraud commented Mar 22, 2016

Does the example need a map?

'#3f48cc', '#a349a4'],
['#b97a57', '#ffaec9', '#ffc90e', '#efe4b0', '#b5e61d', '#99d9ea',
'#7092be', '#c8bfe7'],
['#ffffff', '#f7f7f7', '#c3c3c3', '#000000']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's those default color, from where does come from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From Luxembourg project.
We can define one that fits geomapfish needs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the one in the example comes from the example itself, it is overloaded.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find where he is visible, In the redlining I have a colorpicker from the browser...

I see that it's overloaded in the example but I think that the default value should already be a good chose :-)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used in Luxembourg when <input type="color" is not available, try with IE11.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks, that's looks not so bad :-)

@ger-benjamin
Copy link
Member

Address my comments then it will be ready to merge for me.

@sbrunner sbrunner added this to the 2.1 milestone Mar 24, 2016
@adube
Copy link
Contributor

adube commented Mar 29, 2016

Do you have any idea when this could be merged ? I need it for the editing tools.

@fgravin
Copy link
Member Author

fgravin commented Mar 29, 2016

I'll work a bit on it now.

@fgravin fgravin force-pushed the colorpicker branch 2 times, most recently from f347134 to d745325 Compare March 29, 2016 16:10
@fgravin
Copy link
Member Author

fgravin commented Mar 29, 2016

PR and example updated.
Waiting for Travis to merge.

@pgiraud
Copy link
Contributor

pgiraud commented Mar 29, 2016

The UI looks very good and is much nicer.

@fgravin
Copy link
Member Author

fgravin commented Mar 29, 2016

Thanks @pgiraud, i admit it is wonderfull.

@fgravin fgravin merged commit ea6d88f into camptocamp:master Mar 29, 2016
@fgravin fgravin deleted the colorpicker branch March 29, 2016 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants