Remove Layer group block #1019
Merged
Remove Layer group block #1019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivierSemet
force-pushed
the
PR-remove-layer-group-block
branch
from
f0e996c
to
20c13eb
Compare
|
Are you able to provide a live demo? |
|
check the live demo |
| @@ -13,3 +13,6 @@ | |||
| /examples/simple.min.js | |||
| contribs/gmf/fonts/FontAwesome* | |||
| contribs/gmf/fonts/fontawesome* | |||
|
|
|||
| .idea/ | |||
| tags | |||
There was a problem hiding this comment.
Better to start with a / to be sure that's come from the root folder (same for fonts)...
|
This PR could be affected by the following PR #1011 since the LayerTree behavior has been modified |
| @@ -170,20 +157,41 @@ ngeo.LayertreeController = function($scope, $element, $attrs) { | |||
| * @type {number} | |||
| * @export | |||
| */ | |||
| this.uid = goog.getUid(this); | |||
| this.depth = isRoot ? 0 : this.parent['depth'] + 1; | |||
There was a problem hiding this comment.
?? why changing the declaration order here ?
|
I think something like that was enough for this one <a href="" ng-if="::layertreeCtrl.depth == 1"
ng-click="gmfLayertreeCtrl.removeNode(layertreeCtrl.node)">
<span class="fa fa-trash"></span>
</a> |
olivierSemet
force-pushed
the
PR-remove-layer-group-block
branch
from
8770862
to
a74e1f9
Compare
|
@fgravin could you check please? |
|
Good thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #821