Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ngeo.FeatureProperties values to use a single letter #1061

Merged
merged 1 commit into from Apr 26, 2016

Conversation

adube
Copy link
Contributor

@adube adube commented Apr 25, 2016

This PR renames ngeo.FeatureProperties values to use a single letter, allowing the permalink to use less characters.

  • review

@adube
Copy link
Contributor Author

adube commented Apr 25, 2016

@fgravin (or @fredj), please review.

@adube adube force-pushed the ngeo-features-rename-properties branch from 1b5d2a1 to 1c8fe3e Compare April 25, 2016 16:47
@fredj
Copy link
Member

fredj commented Apr 26, 2016

Looks good to me

@sbrunner
Copy link
Member

I don't find if it's backward compatible, is it?
Can we add some test for that?

@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

@sbrunner Backward compatibility will be managed in #1062.

@adube adube force-pushed the ngeo-features-rename-properties branch from 1c8fe3e to dab8f18 Compare April 26, 2016 12:05
@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

@fredj Rebased onto master. Ready for merge once Travis is happy.

@fredj fredj merged commit 2d28f1e into camptocamp:master Apr 26, 2016
@adube adube deleted the ngeo-features-rename-properties branch April 26, 2016 12:41
@sbrunner
Copy link
Member

Thanks @adube :-)

@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants