Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModifyRectangle - Set corner features in cache item #1067

Merged
merged 2 commits into from Apr 26, 2016

Conversation

adube
Copy link
Contributor

@adube adube commented Apr 26, 2016

This PR is a small fix for the ngeo.interaction.ModifyRectangle interaction. The corner features were put in the feature's own properties, which was causing issues with the permalink.

Now, the corners are stocked in a cache item instead.

Live example

@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

@fredj Ready for review/merge.

@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

I added a live example, which confirms that the issue disappeared. (we used to have object[Object] in the url. They are no longer there).

@adube adube force-pushed the fix-ngeo-modify-rectangle-corners branch from c97010a to 5729224 Compare April 26, 2016 12:47
@fredj
Copy link
Member

fredj commented Apr 26, 2016

LGTM, can you please check if it works in compiled mode? I've a doubt that:

var item = {
  corners: pointFeatures
}

Is correctly detected as a ngeo.interaction.ModifyRectangle.CacheItem by the compiler

@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

It does work, but it's never bad to cast the type (for a dev point of view, it also tells what it is). I'll do this right away.

@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

Done. I'll let you know once Travis passes.

@adube
Copy link
Contributor Author

adube commented Apr 26, 2016

Travis passes.

@fredj
Copy link
Member

fredj commented Apr 26, 2016

Thanks @adube

@fredj fredj merged commit 065171a into camptocamp:master Apr 26, 2016
@adube adube deleted the fix-ngeo-modify-rectangle-corners branch April 26, 2016 15:01
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants