Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layertree's right button use an absolute position close #1068 #1070

Conversation

olivierSemet
Copy link
Contributor

No description provided.

@olivierSemet
Copy link
Contributor Author

@pgiraud could you check? Thank you

@@ -69,15 +70,16 @@
opacity: 0.5;
}

.leaf {
.leaf, .group {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a line break. For readability and consistency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

between .leaf and .group?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
In general, we add a line break after the commas in the less files.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I just took the example just above to write those lines. There is no line break. I'll put a line break.

@olivierSemet olivierSemet force-pushed the 1068-absolute-position-for-rightbuttons branch from d9b8ae6 to cc1bc35 Compare April 27, 2016 08:04
@fredj
Copy link
Member

fredj commented Apr 28, 2016

Can we merge this ? ping @pgiraud

@pgiraud pgiraud merged commit 9d5346d into camptocamp:master Apr 28, 2016
@olivierSemet olivierSemet deleted the 1068-absolute-position-for-rightbuttons branch May 9, 2016 17:36
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants