Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issue with the modify rectangle. #1071

Merged
merged 1 commit into from Apr 27, 2016

Conversation

jlap
Copy link
Contributor

@jlap jlap commented Apr 27, 2016

This commit fixes a glitch with the modify rectangle that only occurs on the built version, and it also fixes a the styling issue in the gmf draw feature example where selecting the rectangle causes the style to be added twice.

This was occurring by a combination of the modify rectangle wanting to manage its own layer of polygons, which really wasn't necessary, and a bad management of added / removed features when creating / removing their corner handles.

The example now working well in the integrated draw feature example is available here: http://jlap.github.io/ngeo/modify-rectangle-style-bug/examples/contribs/gmf/drawfeature.html

The modify rectangle works exactly the same as it used to: http://jlap.github.io/ngeo/modify-rectangle-style-bug/examples/modifyrectangle.html

@jlap
Copy link
Contributor Author

jlap commented Apr 27, 2016

@fredj @fgravin this is ready for review.

@fredj
Copy link
Member

fredj commented Apr 27, 2016

Looks good, thanks

@fredj fredj merged commit 240e98c into camptocamp:master Apr 27, 2016
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants