Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ngeo filters #1125

Merged
merged 1 commit into from
May 9, 2016
Merged

Ngeo filters #1125

merged 1 commit into from
May 9, 2016

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented May 4, 2016 •
edited

@ger-benjamin ger-benjamin force-pushed the ngeo_filters branch 2 times, most recently from cdc8cf8 to 1dcacf6 Compare May 4, 2016 13:55
@ger-benjamin ger-benjamin changed the title (wip) Ngeo filters Ngeo filters May 9, 2016
@ger-benjamin
Copy link
Member Author

ger-benjamin commented May 9, 2016 •
edited

Note that I've applied the removal related here: #1119
(I've removed this line: https://github.com/camptocamp/ngeo/blob/master/src/services/filers.js#L10 )

So for now, scales are always numbers with a comma as separator. That will be resolved by #1119

@fredj
Copy link
Member

fredj commented May 9, 2016

LGTM, thanks

@ger-benjamin ger-benjamin merged commit 1c6c31c into camptocamp:master May 9, 2016
@ger-benjamin ger-benjamin deleted the ngeo_filters branch May 9, 2016 07:15
@sbrunner sbrunner mentioned this pull request May 9, 2016
Closed
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

Tests , doc, architecture of ngeo "filters"
3 participants
@ger-benjamin @fredj @sbrunner