Styling and icon for out of scale nodes #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,4 +53,8 @@ | |||
| &.gmf-icon-text:after { | |||
| content: '\e906'; | |||
| } | |||
|
|
|||
| &.gmf-icon-search-go:after { | |||
| content: '\e908'; | |||
There was a problem hiding this comment.
should use the double dot :: for pseudo element
There was a problem hiding this comment.
Indeed.
Let's be consistent for now and change all the selectors once for all.
Can you please open an issue for addressing this right after that?
pgiraud
force-pushed
the
layertree_out_of_scale
branch
from
33919cb
to
0e28024
Compare
|
The icon don't mean anything at the standard zoom..., should the arrow be moved on the right? |
pgiraud
force-pushed
the
layertree_out_of_scale
branch
from
0e28024
to
362040f
Compare
You're right. I tried to change it a bit. I hope this is a bit clearer. |
|
@pgiraud Yes, wonderful :-) |
|
LGTM |
pgiraud
force-pushed
the
layertree_out_of_scale
branch
from
362040f
to
1539e81
Compare
|
Nice! |
pgiraud
force-pushed
the
layertree_out_of_scale
branch
from
1539e81
to
42b7bd7
Compare
pgiraud
force-pushed
the
layertree_out_of_scale
branch
from
4a5687a
to
8f0a4a0
Compare
|
Space added (with an arbitrary value chosen). Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created an icon, and I hope it's clear enough.
The text is now italic when the layer is out of scale.
IMO the icon is intrusive and no really relevant when the node is not active so I hide it in this case.
Demos:
https://pgiraud.github.io/ngeo/layertree_out_of_scale/examples/contribs/gmf/apps/desktop
https://pgiraud.github.io/ngeo/layertree_out_of_scale/examples/contribs/gmf/apps/mobile
Remaining issues:
Positioning of elements is not perfect and the icon will be visible if the name of the layer is very long.
Please review.