Counter loading icon shaking #1173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll trust you. Let's go with this simple fix. Can you please add a comment in the less file with a pointer to the fontawesome issue? |
ger-benjamin
force-pushed
the
shaking_loading_icon
branch
from
16da578
to
23a8792
Compare
|
Looks good to me. Please merge. |
|
@pgiraud In the Font-Awesome issue, the one that warn us about the blur filter got a problem on Win7/chrome32. I've tested GMF on this browserstack and don't see any problem with the refresh symbol. (Wait on travis) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1140
Example: https://ger-benjamin.github.io/ngeo/shaking_loading_icon/examples/contribs/gmf/apps/desktop
(No board effect found)