-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use absolutes URL for the partiales #1174
Conversation
var urlElements = window.location.pathname.split('/'); | ||
urlElements.pop(); | ||
urlElements.pop(); | ||
urlElements.pop(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you are programming in Logo.. ;)
This could be:
var gmfUrlElements = urlElements.slice(0, urlElements.length - 3);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-) +1
Thanks @tsauerwein, mutch better :-) |
@@ -1,12 +1,21 @@ | |||
var urlElements = window.location.pathname.split('/'); | |||
|
|||
gmfUrlElements = urlElements.slice(0, urlElements.length - 3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var gmfUrlElements = ...
var urlElements = window.location.pathname.split('/'); | ||
|
||
gmfUrlElements = urlElements.slice(0, urlElements.length - 3); | ||
gmfUrlElements.push('src', 'directives', 'partials') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing semicolon
var urlElements = window.location.pathname.split('/'); | ||
|
||
var gmfUrlElements = urlElements.slice(0, urlElements.length - 3); | ||
gmfUrlElements.push('src', 'directives', 'partials') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing semicolons
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is strange than eslint didn't detect it: #1072
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these files not scanned by eslint? The missing var ...
was also not detected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed with 3cde1d7
fix #1171
replace #1121