Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't add a vertex on right click #1180

Merged
merged 1 commit into from
May 10, 2016
Merged

Don't add a vertex on right click #1180

merged 1 commit into from
May 10, 2016

Conversation

fredj
Copy link
Member

@fredj fredj commented May 10, 2016

Fixes #1085

work in progress

@sbrunner
Copy link
Member

Is it ready?

@fredj
Copy link
Member Author

fredj commented May 10, 2016

It's works but not on touch devices

@fredj
Copy link
Member Author

fredj commented May 10, 2016

After discussion with @ybolognini this PR will be merged and improved later

@fredj fredj merged commit 7fd9e7b into camptocamp:master May 10, 2016
@fredj fredj deleted the f_1085 branch May 10, 2016 15:23
@tsauerwein
Copy link

@fredj, could it be that you pushed forced to your ol3 branch? Because the commit referenced in the ngeo package.json does no longer work (fredj/ol3#afb2084).

@tsauerwein
Copy link

Besides this change in ol3 makes the build fail:
openlayers/openlayers@8c8c4c3#diff-8494393ae9d5dabf08260f09d9403203L3

node buildtools/build.js .build/ngeo.json dist/ngeo.js
info ol Parsing dependencies
ERR! Unsatisfied dependency "ol.style.StyleFunction" in script: /home/tsauerwein/projects/ngeo/src/services/featureoverlay.js 
make: *** [dist/ngeo.

@sbrunner
Copy link
Member

see #1184

This was referenced May 10, 2016
Closed
Merged
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

gmf-drawfeature - actions menu - don't add vertex
3 participants
@fredj @sbrunner @tsauerwein