Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include queryable child layers #1288

Merged
merged 2 commits into from May 26, 2016

Conversation

tsauerwein
Copy link

Closes #962

Please review. I am not sure if this PR is complete, it seems that the format for themes.js has changed. E.g. the themes.js file used in the tests uses this format:

{
  "layers": "hotel",
  "name": "hotel",
  "queryable": 1,
  "childLayers": [],
  ...

... while the server returns this format:

{
  "layers": "hotel",
  "name": "hotel",
  "childLayers": [
    {
      "name": "hotel",
      "queryable": false
    }
  ],
  ...
}

Should both be supported?

@tsauerwein tsauerwein added this to the 2.0 milestone May 25, 2016
@sbrunner
Copy link
Member

it seems that the format for themes.js has changed.

Yes it is.

Should both be supported?

No, only the second

@tsauerwein tsauerwein force-pushed the 2.0-non-queryable-childLayers branch from 854af20 to 5a48161 Compare May 26, 2016 13:47
tsauerwein added 2 commits May 26, 2016 15:59
@tsauerwein tsauerwein force-pushed the 2.0-non-queryable-childLayers branch from 5a48161 to bf094a3 Compare May 26, 2016 14:02
@tsauerwein
Copy link
Author

Ok, I updated the themes.js file in the tests accordingly. Ready to review.

@sbrunner
Copy link
Member

Looks good, thanks @tsauerwein

@tsauerwein tsauerwein merged commit 8369f53 into camptocamp:2.0 May 26, 2016
@tsauerwein tsauerwein deleted the 2.0-non-queryable-childLayers branch May 26, 2016 14:59
@tsauerwein tsauerwein mentioned this pull request Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants