Rename MobileBackgroundLayerSelector --> BackgroundLayerSelector #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@adube there is still some string to rename (you can find them with |
adube
force-pushed
the
background-layer-selector
branch
from
098f758
to
08bbf71
Compare
|
Fixed. Anything else to review ? |
|
Looks good for me :-) |
|
please fix the comment: and it will be good to merge |
|
On it. |
|
Done |
|
Thanks, I will merge when travis is green. |
|
Travis is green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the
MobileBackgroundLayerSelector-->BackgroundLayerSelector, which is the first step required toward making the desktop version, i.e. both will share theBackgroundLayerSelector.Todo
Live demos
Just to show that the mobile version is still working fine: