Add background layer selector as 'drop-down' button in desktop apps #1299
Conversation
|
Ready for review. |
| <button | ||
| class="btn btn-default" | ||
| data-toggle="dropdown"> | ||
| <img src="https://cloud.githubusercontent.com/assets/319774/13696817/1cc9a7ee-e769-11e5-85c8-a1ea5ff21a5d.png" alt="" /> |
There was a problem hiding this comment.
We don't want to add the image in the repository?
There was a problem hiding this comment.
We should definitely use a local image. It was OK to use a URL only in a prototype context.
There was a problem hiding this comment.
Understood. I'm on it.
|
Image isn't shown on github.io. |
It doesn't show in built mode I think. You have to use the same strategy as for the geomapfish logo. |
|
@adube you should do some thing like that #1291 (comment), and what about put the image in |
|
O~kay! All raised issues have been fixed. Let me know if you need me to fix anything else. |
|
@sbrunner Yeah, that's what has just been done. The image was put in the |
|
OK :-) |
|
This looks good to me. Can you please squash the commits? |
adube
force-pushed
the
bls-in-desktop-apps
branch
from
6296d22
to
c2de8ed
Compare
|
"Squashing squashing..." |
|
Quick unrelated question: I was told a few weeks ago that it wasn't required anymore to squash commits into once since it's now possible to automatically do so when merging on Github. I used to always squash the commits, but was told that I wasn't forced to do so anymore. Is that still the case ? I'm okay with doing one or the other, but let's agree on just one way to go. I think I'd slightly prefer "not squashing" them manually. This makes it easier for reviewers. If one asks: "please, fix this" then he or she can immediately see in the next commit that it has been fixed without having to look at the whole code again. What do you think ? |
adube
force-pushed
the
bls-in-desktop-apps
branch
from
c2de8ed
to
28678ba
Compare
|
Is this ready to be merged ? |
|
ready, I will merge when travis is green |
This PR is the replacement of #1291. It adds the
gmf-backgroundlayerselectorinside both desktop applications using contextual menu customized to look like a button.Original commit: pgiraud@9f6b0a1
Todo
Live demos