Support modal disclaimers

[adube]

This PR adds the possibility to display disclaimer messages as modals instead of alerts in the disclaimer service (ngeo). The gmf.disclaimer directive now has an option that allows to turn this feature on (defaults to off).

The gmf layer tree example has been modified to be able to show this in action using a url parameter.

Note: this PR currently includes the content of #1341, since it hasn't been merged yet.

Todo

• wait for Add gmf-disclaimer directive #1341 to be merged
• review
• apply reviewer's corrections

Live demos

• (use modals) https://adube.github.io/ngeo/gmf-modal-disclaimer/examples/contribs/gmf/layertree.html?modal=true
• (use alerts, default behavior) https://adube.github.io/ngeo/gmf-modal-disclaimer/examples/contribs/gmf/layertree.html?modal=false

[adube]

Ready for review, and I expect to have lots of comments.

[ger-benjamin]

Please prefere this.modal = this.modal === true ? this.modal : false; for this test.
Else modal can be toto or null etc.

[adube]

I don't understand what you mean. this.modal should be false by default.

[tsauerwein]

If you set up the directive with something like ... gmf-disclaimer-modal="ctrl.map"..., this.modal will be a map object. This is why @ger-benjamin prefers to use this.modal = this.modal === true.

I would use two different variables. E.g. set up the scope with:

    scope: {
     'modalIn': '<?gmfDisclaimerModal', 

And then in your controller:

  /**
   * @type {boolean}
   * @export
   */
  this.modal = this['modalIn'] === true;

This way you are sure that this.modal always has the correct type.

[adube]

That's a nice trick. I'll do this.

[ger-benjamin]

Result is strange on opening mutliple popups at the same time. Can you open an issue with that ?

[adube]

Result is strange on opening mutliple popups at the same time. Can you open an issue with that ?

See: #1357

[adube]

Corrections applied. Ready for merge.

[sbrunner]

simpler with the exact same result...

this.modal = modal === 'true';

[sbrunner]

Just a micro comment also that's looks good :-)

[adube]

Rebased onto master and tiny fixed applied.

[sbrunner]

Thanks :-)