Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update OpenLayers #1419

Merged
merged 1 commit into from
Jun 22, 2016
Merged

Update OpenLayers #1419

merged 1 commit into from
Jun 22, 2016

Conversation

fredj
Copy link
Member

@fredj fredj commented Jun 16, 2016

work in progress

@tsauerwein
Copy link

@fredj Did you continue the work on this? For #1335 I will have to make a PR on ol and I would then need to update ol in ngeo.

@fredj
Copy link
Member Author

fredj commented Jun 22, 2016

@tsauerwein yes, I'm on it

@fredj fredj changed the title Update openlayers to 6fe1a58 Update OpenLayers Jun 22, 2016
@fredj
Copy link
Member Author

fredj commented Jun 22, 2016

@tsauerwein the tests are failing (in test/spec/services/query.spec.js) but I don't know why, Do you have any clue?

@tsauerwein
Copy link

See tsauerwein@a12d921

In the url it is now &STYLE=&... instead of &STYLE&...

@fredj
Copy link
Member Author

fredj commented Jun 22, 2016

good catch ! thanks

@tsauerwein
Copy link

Thanks for updating! Your changes look good to me.

@fredj
Copy link
Member Author

fredj commented Jun 22, 2016

Thanks for the review

@fredj fredj merged commit 6039de9 into camptocamp:master Jun 22, 2016
@fredj fredj deleted the update_ol branch June 22, 2016 08:20
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredj @tsauerwein @sbrunner