Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use pager for git attributes check #1433

Merged
merged 1 commit into from
Jun 20, 2016
Merged

Do not use pager for git attributes check #1433

merged 1 commit into from
Jun 20, 2016

Conversation

tsauerwein
Copy link

sbrunner
sbrunner reviewed Jun 20, 2016
View reviewed changes
Makefile
@@ -167,7 +167,7 @@ lint: .build/eslint.timestamp

.PHONY: git-attributes
git-attributes:
git diff --check HEAD~40
git --no-pager diff --check HEAD~40
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The options shouldn't be after the diff?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, before.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively, thanks :-)

@sbrunner
Copy link
Member

Looks good, merge when Travis is happy :-)

@tsauerwein tsauerwein merged commit 9155115 into camptocamp:master Jun 20, 2016
@tsauerwein tsauerwein deleted the diff-no-pager branch June 20, 2016 10:03
@tsauerwein
Copy link
Author

Thanks for the review

@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsauerwein @sbrunner