Add gmf-mobile-nav-back-on-click directive #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And use it to close the gmf-themeselector on mobile.
| * gmf-mobile-nav-back-on-click | ||
| * gmf-themeselector-currenttheme="mainCtrl.theme"> | ||
| * </gmf-themeselector> | ||
| * |
There was a problem hiding this comment.
This directive has no html attributes
There was a problem hiding this comment.
Sorry I just see the attributes from the theme selector, add ..., forget my comment :-)
|
This is a pretty elegant workaround. |
|
Thanks for the review |
|
@fredj did you check if there are still cases where we want to keep the previous |
|
yes, |
|
If it's not used, I'm in favour to remove it. It adds unrequired complexity. This "back-click" directive is much more easy to use and understand and is useful in many contexts. |
|
ok, and the code is in the git history if needed |
|
I will create a PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use it to close the gmf-themeselector on mobile.
Fixes #1344