Better layout for bg and theme selectors using flex #1448
Conversation
pgiraud
force-pushed
the
selectors_layout
branch
from
f5b6760
to
758be15
Compare
|
Is it not better to have first images and then descriptions? Because currently the images are more closer to the other column... Current Proposition |
|
Nice suggestion @rbovard. And it will make it easier to customize (no HTML changes) if you want the text below the image like it's done in 1.6. |
pgiraud
changed the title
pgiraud
force-pushed
the
selectors_layout
branch
2 times, most recently
from
90a84ed
to
4cbc658
Compare
|
@rbovard suggestion taken into account.
Enjoy and review please. Démos: |
|
I enjoyed! Thanks for this nice work :) |
pgiraud
force-pushed
the
selectors_layout
branch
from
4cbc658
to
31c76a1
Compare
pgiraud
changed the title
| } | ||
| display: flex; | ||
| align-items: center; | ||
| min-height: 30px; |
There was a problem hiding this comment.
Because the thumbnails are images. The size of the images are given in pixels. This value prevents the blank background layer to be displayed with a completely different layout.
There was a problem hiding this comment.
By the way, this min-height should go into .gmf-thumbnail.
There was a problem hiding this comment.
Because the thumbnails are images. The size of the images are given in pixels. This value prevents the blank background layer to be displayed with a completely different layout.
No relation about using px or rem, and the image is 60px height...
|
Only one question. Then it's ready to merge IMO. |
|
Just don't forget to relate this PR to an issue. |
pgiraud
force-pushed
the
selectors_layout
branch
from
31c76a1
to
f24a2d3
Compare
|
Comments taken into account. Merging. Thanks for the reviews. |
Title says it all.
Démo: http://pgiraud.github.io/ngeo/selectors_layout/examples/contribs/gmf/apps/desktop/