Add gmf.XSDAttributes service #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
changed the title
adube
force-pushed
the
gmf-xsdattributes-service
branch
from
506b1fd
to
0af6af1
Compare
adube
force-pushed
the
gmf-xsdattributes-service
branch
from
0af6af1
to
d59db7b
Compare
adube
changed the title
|
@fredj Ready for review. |
|
Looks very good, I will merge when travis is happy |
|
@fredj Travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
gmf.XSDAttributesservice, which is responsible of communicating with a GeoMapFish server to get the attributes of a layer in XSD format, convert them to an array ofngeox.Attributeobjects.It only sends the request for a single layer once using a promise.
Todo
That's the 3rd PR which completes the work of the "XSD Parser" task. It currently includes the other 2 as well because none of them have been merged yet. Let's wait for them to be merged before reviewing.
Live example