Add gmf.EditFeature service with example #1459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbrunner Would you please look at the "Same origin" issue I'm having ? Thanks. |
adube
force-pushed
the
gmf-editfeature-service
branch
4 times, most recently
from
61b3708
to
d98dad0
Compare
|
@fredj You can review right away, if you want. |
adube
force-pushed
the
gmf-editfeature-service
branch
2 times, most recently
from
da88467
to
abac4e4
Compare
|
can you please update the demo ? |
|
Yes, I'm on it. |
|
Demo updated. I'll check at the travis issue now. |
adube
force-pushed
the
gmf-editfeature-service
branch
2 times, most recently
from
a23e3fa
to
aa36d75
Compare
|
@adube please create a new issue for the CORS issue at https://github.com/camptocamp/c2cgeoportal/issues |
| goog.require('ol.geom.Point'); | ||
| goog.require('ol.layer.Tile'); | ||
| goog.require('ol.source.OSM'); | ||
|
|
There was a problem hiding this comment.
missing goog.require('goog.asserts');
|
Looks good, please fix the missing require and this can be merged |
adube
force-pushed
the
gmf-editfeature-service
branch
from
aa36d75
to
0650b8e
Compare
|
Fixed and ready for merge once Travis is happy. Thanks for the review. Issue about CORS created as well (see in the description above). |
|
@fredj Travis is happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
gmf.EditFeatureservice along with a simple example that demonstrates what you can do with it. The example should be replaced in the incoming days with one that uses the "coming soon" directives that allows the user to actually select an editable layer first.Same origin issues
When trying to insert, update or delete, we get errors:
Todo
Fix the "Same origin" issues, moved to: CORS issue with feature edit requests c2cgeoportal#2368Live example