Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gmf EditFeature service header #1505

Merged
merged 1 commit into from
Jul 4, 2016
Merged

Fix gmf EditFeature service header #1505

merged 1 commit into from
Jul 4, 2016

Conversation

adube
Copy link
Contributor

@adube adube commented Jun 30, 2016 •
edited

This PR fixes the gmf.EditFeature service to use the correct header in the POST, PUT and DELETE requests it sends.

Todo

  • solve the goog is not defined error in the example
  • review

Live example

@adube
Copy link
Contributor Author

adube commented Jun 30, 2016

Mmm, not sure why but I get a goog is not defined in the example due the the assertions that are made. I thought those were supposed to be automatically removed.

What is the way to fix this ?

@fredj
Copy link
Member

fredj commented Jul 4, 2016

Look like our examples doesn't support goog.asserts. Only goog.provide and goog.require are stripped.

What about replacing goog.asserts with console.assert?

@fredj fredj merged commit 0247dac into camptocamp:master Jul 4, 2016
@fredj fredj mentioned this pull request Jul 4, 2016
Merged
@adube adube deleted the fix-gmf-editfeature-service branch July 18, 2016 12:34
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adube @fredj @sbrunner