Display azimuth of circles in the redlining tools #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgiraud
force-pushed
the
azimuth
branch
2 times, most recently
from
43d545f
to
e7ed26d
Compare
pgiraud
changed the title
|
Please review. |
pgiraud
changed the title
|
Done UI tests. Looks good |
|
For me thats looks ok :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1573
I reworked @jlap 's pull request to make it simpler (well I hope).
Instead of storing the radius line geometry, only the azimut is kept as a property of the feature.
Also, the placement of the azimut value on the map is computed using the point which is on the circle instead of a complex computation with an offset from the center.
Also the radius value and the position of the azimut update correctly if the circle is modified.
Finally, the radius length displays along the line (ie. oriented).
Demo:
http://pgiraud.github.io/ngeo/azimuth/examples/contribs/gmf/drawfeature.html
https://pgiraud.github.io/ngeo/azimuth/examples/contribs/gmf/apps/desktop
Still missing: update of the azimut value when modifying the circle.