Better way to handle precision + switch to km at 1000m #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgiraud
force-pushed
the
measure_precision
branch
from
4b86d2f
to
1ee4eed
Compare
|
Please review. |
| if (length > 100) { | ||
| output = (Math.round(length / 1000 * 100) / 100) + | ||
| if (length > 1000) { | ||
| output = parseFloat((length / 1000).toPrecision(3)) + |
There was a problem hiding this comment.
Why is parseFloat necessary?
There was a problem hiding this comment.
In order not to get exponential notations.
(ie. 1e6)
There was a problem hiding this comment.
Understood. Please merge.
pgiraud
pushed a commit
that referenced
this pull request
Feb 24, 2015
Better way to handle precision + switch to km at 1000m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.