Handle one level of background groups #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group will appear in the background selector. Selecting the group will activate child layers. All children of a group are assumed to be plain layers. Supported dimensions are read from the group.
Handle 1 level of children.
gberaudo
force-pushed
the
background_groups
branch
from
7101a65
to
033133d
Compare
|
Looks good for me :-) |
|
Thanks for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group will appear in the background selector.
Selecting the group will activate child layers.
All children of a group are assumed to be plain layers.
Supported dimensions are read from the group.
In addition, trigger a source refresh on dimension change.