Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix properties not defined on Object #1698

Merged
merged 1 commit into from
Aug 16, 2016

Conversation

adube
Copy link
Contributor

@adube adube commented Aug 15, 2016

In an application where we include ngeo alongside other libraries and in which we compile them all together using Compiler Compiler, we get errors like this one:

ERR! compile ngeo/ol-ext/format/featurehash.js:590:
ERROR - Property pointRadius never defined on Object<string,(boolean|number|string)>
ERR! compile   pointRadius = properties.pointRadius;

I checked if the minimized JavaScript file produced by the build script within ngeo and these properties stay as is, i.e. the compiler don't rename them. In our app, it would. This patch fixes this.

@fredj
Copy link
Member

fredj commented Aug 16, 2016

LGTM

@fredj fredj merged commit 5d44871 into camptocamp:master Aug 16, 2016
@adube adube deleted the fix-style-properties branch August 16, 2016 12:05
@adube
Copy link
Contributor Author

adube commented Aug 16, 2016

Thanks

@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants