Use the default_theme value from the login #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have time today to rebase this PR then provide an example ? (I'm supposed to review this PR) |
| // currentTheme = gmf.Themes.findThemeByName(this.themes, this.defaultTheme); | ||
| // } | ||
|
|
||
| // this.setTheme(/** @type {GmfThemesNode} */ (currentTheme), true); |
There was a problem hiding this comment.
Shouldn't we remove this commented code?
There was a problem hiding this comment.
still in "work in progress" ...
|
It can't be tested because this pull request depends on camptocamp/c2cgeoportal#2456 and geomapfish-demo.camptocamp.net is not yet updated |
fredj
force-pushed
the
default_theme
branch
2 times, most recently
from
a876a0c
to
281c426
Compare
|
Demo updated :-) |
fredj
force-pushed
the
default_theme
branch
from
4fe6271
to
9243050
Compare
And check the user functionalities from a 'default_theme'
fredj
force-pushed
the
default_theme
branch
from
9243050
to
5fdba09
Compare
|
@sbrunner still no |
fredj
changed the title
|
But we can merge and check later with the demo |
|
@sbrunner ready to be reviewed |
|
ping @sbrunner |
|
For me that's looks good :-) |
|
Thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #654