Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n search actions #1768

Merged
merged 1 commit into from
Sep 5, 2016
Merged

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Aug 30, 2016

Fix: #1764

Example: https://ger-benjamin.github.io/ngeo/i18naddlayers/examples/contribs/gmf/apps/desktop_alt

Is that okay with this solution ?
I think it's good enough. We don't add new actions all day. If that become problematic with further dev, we can adapt the server part to add actions directly in english.

@ger-benjamin
Copy link
Member Author

Ping

@sbrunner
Copy link
Member

sbrunner commented Sep 5, 2016

Shouldn't we change gmfSearchActions` to ?:

module.value('gmfSearchActions', [
    { action: 'add_theme', name: gettextCatalog.getString('Add a theme') },
    { action: 'add_group', name: gettextCatalog.getString('Add sub theme') },
    { action: 'add_layer', name: gettextCatalog.getString('Add a layer') }
]);

@ger-benjamin
Copy link
Member Author

You're right. I'll do that soon

@ger-benjamin ger-benjamin changed the title I18n search actions [wip] I18n search actions Sep 5, 2016
@ger-benjamin ger-benjamin changed the title [wip] I18n search actions I18n search actions Sep 5, 2016
@ger-benjamin
Copy link
Member Author

ger-benjamin commented Sep 5, 2016

@sbrunner Done, but I can't translate the title directly in the html

Edit: must add title in string to be translated... wip..

@ger-benjamin ger-benjamin changed the title I18n search actions [wip] I18n search actions Sep 5, 2016
@ger-benjamin ger-benjamin changed the title [wip] I18n search actions I18n search actions Sep 5, 2016
@ger-benjamin
Copy link
Member Author

Done this time

@sbrunner
Copy link
Member

sbrunner commented Sep 5, 2016

Looks good to me :-)

@ger-benjamin ger-benjamin merged commit a3fa20e into camptocamp:master Sep 5, 2016
@ger-benjamin ger-benjamin deleted the i18naddlayers branch September 5, 2016 14:19
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n error with add_layer, add_group, add_theme
2 participants