Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX when no editable layers #1793

Merged
merged 3 commits into from
Sep 9, 2016
Merged

Improve UX when no editable layers #1793

merged 3 commits into from
Sep 9, 2016

Conversation

tsauerwein
Copy link

@tsauerwein tsauerwein commented Sep 2, 2016 •
edited

  • Only show edit tool if there is one editable layer in one of the themes (no matter if visible or not).
  • Show message instead of an empty select box when no editable layer in the map.

Closes #1766

@sbrunner
Copy link
Member

sbrunner commented Sep 2, 2016

?? the customer ask to don't have the tool icon...

@tsauerwein tsauerwein changed the title Show message if no editable layers Improve UX when no editable layers Sep 9, 2016
@tsauerwein
Copy link
Author

Updated PR

@sbrunner
Copy link
Member

sbrunner commented Sep 9, 2016

Looks good to me :-)

@tsauerwein tsauerwein merged commit 695ae2a into camptocamp:master Sep 9, 2016
@tsauerwein tsauerwein deleted the no-edit-layers branch September 9, 2016 11:59
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

The editing shouldn't be desplayed only on users that's allow to edit
2 participants
@tsauerwein @sbrunner