Make tool panel scrollable in sidebar #1794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks. Please merge. |
|
Thanks for the review! |
pgiraud
pushed a commit
that referenced
this pull request
Sep 7, 2016
Follow up of #1794 We could also only allow vertical scroll on tools panels.
pgiraud
pushed a commit
that referenced
this pull request
Sep 7, 2016
Follow up of #1794 We could also only allow vertical scroll on tools panels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the tool panel in the right panel scrollable. At first I tried to keep the panel title fixed, and only make the panel content area scrollable. But this caused several layouting issues, which would require more profound changes. Considering that usually the vertical space is sufficient, I would propose to go with this simple but effective solution. If wanted we can still improve it later.
Closes #1738