#1680 - Fix CSS class name in gmf-mouseposition directive #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
force-pushed
the
1680-css-fix-mouseposition
branch
from
1984404
to
26a1d66
Compare
adube
force-pushed
the
1680-css-fix-mouseposition
branch
from
26a1d66
to
a2ba0fb
Compare
|
LGTM. +100 to stop using ids or global objects (ex: |
|
@gberaudo Thanks. I'll go ahead and create issues for the If you wish for me to work on them right away, then you can assign them to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the CSS class name for the gmf mouseposition directive. Changes are made in the example and and desktop application. See #1680. Note that this is one among many PR that will come to fix #1680.
The use of an
idwithin the directive is not a good practice. If one wanted to have 2 maps with each their own mouse positions directive, then it wouldn't work because the directive appends the created control using the id of the element defined within the template. That's not an issue for now, but this could be changed.Instead of using the id in the CSS, the class name of the control itself is used.
Todo
Live examples