Fix treemanager missing require #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
force-pushed
the
fix-treemanager
branch
from
f7aa3d3
to
d961a50
Compare
pgiraud
approved these changes
Sep 19, 2016
|
Thanks for the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
gmf.TreeManagerservice.ngeo.StateManagergmf.PermalinkParam.TREE_GROUPSconstant but was not requiring the permalink service. In the end, we can't do that because the permalink service already requires the tree manager as well and we would end up with a circular dependency. To fix that, the constantgmf.PermalinkParamwas moved togmf.js.I found this out while trying to view the theme selector example, which didn't work on dev.
Todo
Live example