Add an option to bypass the local storage #1882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gberaudo
reviewed
Sep 21, 2016
| @@ -146,6 +146,10 @@ gmf.Permalink = function($timeout, ngeoBackgroundLayerMgr, ngeoDebounce, | |||
| */ | |||
| this.ngeoStateManager_ = ngeoStateManager; | |||
|
|
|||
| if (gmfPermalinkOptions.useLocalStorage === false) { | |||
| this.ngeoStateManager_.localStorage = null; | |||
There was a problem hiding this comment.
Maybe use the hash { 'isAvailable': function() {return false;}}?
There was a problem hiding this comment.
Or even this.ngeoStateManager_.localStorage.isAvailable = ol.functions.FALSE; ?
There was a problem hiding this comment.
Yes any way is +1. Thanks for asking.
sbrunner
changed the title
fredj
changed the title
fredj
force-pushed
the
localstorage_off
branch
from
c71ea92
to
32071e8
Compare
Add a new options to gmfx.PermalinkOptions to deactivate to storage into the local storage. The desktop_alt now uses this option.
fredj
force-pushed
the
localstorage_off
branch
from
32071e8
to
b94b095
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new options to gmfx.PermalinkOptions to deactivate to storage into the local storage.
The desktop_alt now uses this option.