Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tested themes.json #1958

Merged
merged 1 commit into from
Oct 19, 2016

Conversation

ger-benjamin
Copy link
Member

@ger-benjamin ger-benjamin commented Oct 18, 2016

Fix #1885

Done:

  1. Tested themes.json is up to date (18 october 2016)
  2. The old_themes is no more used (is removed)
  3. A lot of now useless FIXME (in tests) have been removed
  4. Debug contribs/gmf/test/spec/services/querymanager.spec.js (on test is still in FIXME but that's out of this PR scope)

Question:
How can we do that ? Then, if we want that tests are useful, we should use a real server response and not use a static file. Or find a method to update the fake server response when the database change...
Just by update this themes.json file manually every month ?

@ger-benjamin ger-benjamin changed the title [WIP]Update tested themes.json Update tested themes.json Oct 19, 2016
@sbrunner
Copy link
Member

Thanks a lot :-)

Question...

Good question...

@ger-benjamin ger-benjamin merged commit 2c3fb62 into camptocamp:master Oct 19, 2016
@ger-benjamin ger-benjamin deleted the updateTestedThemes branch October 19, 2016 09:34
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tests are based on an old 'Themes' server response object...
2 participants