Fix translations #2185
Merged
Fix translations #2185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
gberaudo
reviewed
Jan 12, 2017
| ng-click="loading ? cancel() : handleFile()"> | ||
| <span>{{userMessage | translate }}</span> | ||
| ng-click="loading ? cancel() : handleFile()" | ||
| translate> |
There was a problem hiding this comment.
You need to keep using the translate filter. Why is this change needed?
gberaudo
reviewed
Jan 12, 2017
| ng-click="loading ? cancel() : handleFileUrl()"> | ||
| {{userMessage | translate}} | ||
| ng-click="loading ? cancel() : handleFileUrl()" | ||
| translate> |
gberaudo
requested changes
Jan 13, 2017
|
According to angular-gettext doc it should work. But ok if it's necessary. |
oterral
force-pushed
the
teo_translate
branch
from
0e78d70
to
9b07e3e
Compare
|
@gberaudo filter re-added |
oterral
force-pushed
the
teo_translate
branch
from
9b07e3e
to
1c689bd
Compare
sbrunner
approved these changes
Jan 16, 2017
|
gberaudo
approved these changes
Jan 16, 2017
|
Waiting for the build to finish. Will merge as soon as Travis is green. |
|
Thanks @oterral. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replace uses of
gettextCatalogbygettextto fix the translation and also remove use of tranlsate filter when it's unneeded.