Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return null if x,y or z in NaN #2415

Merged
merged 1 commit into from Mar 8, 2017
Merged

Return null if x,y or z in NaN #2415

merged 1 commit into from Mar 8, 2017

Conversation

ger-benjamin
Copy link
Member

Fix #2381

@fredj
Copy link
Member

fredj commented Mar 8, 2017

isNaN(undefined) === true but isNaN(null) === false !

@ger-benjamin
Copy link
Member Author

ger-benjamin commented Mar 8, 2017 •
edited

Yes, but that's always to test a value after a parseFloat.
And a parseFloat can only return a number or NaN (never undefined, never null)
(parseInt do the same)

@ger-benjamin ger-benjamin merged commit 43fb139 into camptocamp:2.1 Mar 8, 2017
@ger-benjamin ger-benjamin deleted the use_default_view branch March 8, 2017 12:43
@ger-benjamin ger-benjamin mentioned this pull request Mar 8, 2017
Closed
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ger-benjamin @fredj @sbrunner