Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query the layer only on when he is visible #2425

Merged
merged 1 commit into from Mar 10, 2017
Merged

Query the layer only on when he is visible #2425

merged 1 commit into from Mar 10, 2017

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Mar 9, 2017

Fix #2356

@sbrunner sbrunner force-pushed the query branch 15 times, most recently from 74dd0e6 to ba1db83 Compare March 10, 2017 07:14
@sbrunner sbrunner added this to the 2.1 milestone Mar 10, 2017
@sbrunner sbrunner requested a review from fredj March 10, 2017 08:19
fredj
fredj reviewed Mar 10, 2017
View reviewed changes
examples/mapquery.js
@@ -99,7 +99,8 @@ app.MainController = function($scope, ngeoQuery, ngeoToolActivateMgr) {
});
ngeoQuery.addSource({
'id': busStopSourceId,
'layer': busStopLayer
'layer': busStopLayer,
layers: ['bus_stop']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add quotes around key? 'layers'

fredj
fredj reviewed Mar 10, 2017
View reviewed changes
examples/mapquery.js
@@ -112,7 +113,8 @@ app.MainController = function($scope, ngeoQuery, ngeoToolActivateMgr) {
});
ngeoQuery.addSource({
'id': informationSourceId,
'layer': informationLayer
'layer': informationLayer,
layers: ['information']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add quotes around key? 'layers'

@sbrunner sbrunner merged commit 7c644b4 into 2.1 Mar 10, 2017
@sbrunner sbrunner deleted the query branch March 10, 2017 09:16
@fredj fredj mentioned this pull request Mar 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @fredj