Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Use '@camptocamp/closure-util' npm package #2595

Closed
wants to merge 1 commit into from

Conversation

fredj
Copy link
Member

@fredj fredj commented May 5, 2017

Use a "scoped" npm package for closure-util (from our fork at camptocamp).

comments welcome

@sbrunner sbrunner added this to the 2.2 milestone Jun 9, 2017
@@ -42,7 +42,7 @@ module.exports = function(config) {
'node_modules/bootstrap/dist/js/bootstrap.js',
'node_modules/floatthead/dist/jquery.floatThead.js',
'node_modules/proj4/dist/proj4-src.js',
'node_modules/d3/d3.js',
'node_modules/d3/build/d3.js',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good can you rebase and merge ?
(error travis: is the fork uptodate ?)

@sbrunner sbrunner modified the milestones: 2.3, 2.2 Jun 13, 2017
@fredj fredj changed the title Use '@camptocamp/closure-util' npm package [wip] Use '@camptocamp/closure-util' npm package Jun 13, 2017
@fredj
Copy link
Member Author

fredj commented Oct 12, 2017

see #2974

@fredj fredj closed this Oct 12, 2017
@fredj fredj deleted the scoped_closure-util branch October 12, 2017 06:43
@sbrunner sbrunner modified the milestones: 2.3, dummy Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants