Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide vertical swipe #2783

Merged
8 commits merged into from Aug 9, 2017
Merged

Provide vertical swipe #2783

8 commits merged into from Aug 9, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 31, 2017

romanzoller
romanzoller approved these changes Aug 9, 2017
View reviewed changes
Copy link

@romanzoller romanzoller left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise, tested on a samsung tablet and it works 👍

contribs/gmf/src/directives/swipe.js Outdated
}]);
}

// Down is negative X-coordinate, up is positive.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be Y-coordinate?

@ghost ghost merged commit a135fde into master Aug 9, 2017
@ghost ghost deleted the feature-GSGMF-12-swipe-results-window-down-and-up branch August 9, 2017 12:20
@sbrunner sbrunner modified the milestones: 2.2, 2.2.0 Apr 12, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @romanzoller