Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix move/resize issues and improve styling #2797

Merged
merged 3 commits into from Aug 11, 2017

Conversation

romanzoller
Copy link

  • Fix issue with "share map" modal that was not resizeable
  • Make query results window draggable and resizable
  • Adapt styling of modals in gmf

See https://jira.camptocamp.com/browse/GSGMF-8

Roman Zoller added 3 commits August 2, 2017 17:10
Fix issue where destroying and recreating the modal content was breaking
the resizable functionality.

This fixes the issue with the "share map" modal that was not resizable.
Make them look like other gmf components.
@romanzoller romanzoller force-pushed the fix-move-resize-issues-GSGMF-9-GSGMF-10 branch from ba7ff6a to 8f89451 Compare August 7, 2017 07:26
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanzoller romanzoller merged commit 81bcbbe into master Aug 11, 2017
@romanzoller romanzoller deleted the fix-move-resize-issues-GSGMF-9-GSGMF-10 branch August 11, 2017 10:15
@romanzoller
Copy link
Author

Thanks for the reviews!

@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants