Support user functionalities to toggle the filter tool on upon init #2808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gberaudo
requested changes
Aug 10, 2017
contribs/gmf/externs/gmf-themes.js
Outdated
| * | ||
| * @type {Array.<!string>|undefined} | ||
| */ | ||
| gmfThemes.GmfFunctionalities.prototype.open_layer_filter_panel; |
There was a problem hiding this comment.
The functionality should be open_panel and contain ['layer_filter'] to open that panel.
| const defaultTheme = functionalities.default_theme; | ||
| if (defaultTheme.length > 0) { | ||
| themeName = defaultTheme[0]; | ||
| } |
| this.defaultFiltrableDataSourceName_ = usrFunc['preset_layer_filter'][0]; | ||
| } else { | ||
| this.defaultFiltrableDataSourceName_ = undefined; | ||
| } |
There was a problem hiding this comment.
Could be simplified to this.defaultFiltrableDataSourceName_ = usrFunc && usrFunc['preset_layer_filter'] && usrFunc['preset_layer_filter'][0].
There was a problem hiding this comment.
That would set a false value. I want an undefined value. Anyway, having a simplified version of this is not that useful since it already gets minimized and simplified automatically when building the minimized version. I'll leave this as it is.
There was a problem hiding this comment.
You can try it, that would set an undefined value. But fine to me to keep as you did.
adube
force-pushed
the
open-filter-panel
branch
from
f3b31eb
to
a7a380c
Compare
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the support of the two following GMF user "functionalities":
"open_layer_filter_panel": ["true"]- when defined, the filter panel is open upon loading a desktop application."preset_layer_filter": ["inventaire_equipements"]- when defined, the name of the layer (data source) automatically: 1) open the filter panel, 2) select the data source in the filter selector tool.