Allow overwriting of map_tooltip and map_crosshair #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Aug 24, 2017
| /** | ||
| * Sets the map crosshair to the center (or the map center if nothing provided). | ||
| * Overwrites an existing map crosshair. | ||
| * @param {?ol.Coordinate|undefined} center Optional center coordinate. |
There was a problem hiding this comment.
Instead of having {?ol.Coordinate|undefined} use {?ol.Coordinate=} an rename the parameter to opt_center.
This is the standard way for optional parameter with the closure compiler.
fredj
reviewed
Aug 24, 2017
| * Sets the map tooltip to the center (or the map center if nothing provided). | ||
| * Overwrites an existing map tooltip. | ||
| * @param {string} tooltipText Text to display in tooltip. | ||
| * @param {?ol.Coordinate|undefined} center Optional center coordinate. |
fredj
reviewed
Aug 24, 2017
| * Sets the map crosshair to the center (or the map center if nothing provided). | ||
| * Overwrites an existing map crosshair. | ||
| * @param {?ol.Coordinate|undefined} center Optional center coordinate. | ||
| * @export |
There was a problem hiding this comment.
If this function is not used in a html template, the @export is not needed
|
please merge if you think it's ready |
pfirpfel
added a commit
to pfirpfel/ngeo
that referenced
this pull request
Oct 30, 2017
* Add setter for map crosshair * Add setter for tooltip
pfirpfel
added a commit
that referenced
this pull request
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.