Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused import of $compile #2945

Merged
merged 2 commits into from Oct 2, 2017

Conversation

pfirpfel
Copy link
Contributor

@pfirpfel pfirpfel commented Oct 2, 2017

Was looking for usages of $compile to have an example. $compile gets injected but not used here.
I checked the history of the file, $compile was never used. Probably a leftover from development.

@@ -121,8 +120,8 @@ ngeo.module.directive('ngeoDrawfeature', ngeo.drawfeatureDirective);
* @ngdoc controller
* @ngname ngeoDrawfeatureController
*/
ngeo.DrawfeatureController = function($scope, $compile, $sce,
gettextCatalog, ngeoDecorateInteraction, ngeoFeatureHelper, ngeoFeatures) {
ngeo.DrawfeatureController = function($scope, $sce, gettextCatalog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing comma

@pfirpfel pfirpfel merged commit 14b21ee into camptocamp:master Oct 2, 2017
@pfirpfel pfirpfel deleted the remove-unused-compile branch October 20, 2017 07:03
@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants