Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing datasource attribute to mapfish-print externs #2961

Merged
merged 2 commits into from Oct 11, 2017

Conversation

pfirpfel
Copy link
Contributor

@pfirpfel pfirpfel commented Oct 9, 2017

@pfirpfel pfirpfel changed the title Adding missing datasource attribute Adding missing datasource attribute to mapfish-print externs Oct 9, 2017
@fredj
Copy link
Member

fredj commented Oct 9, 2017

@sbrunner is {Array} correct? or can we have an other type for the datasource ?

@fredj
Copy link
Member

fredj commented Oct 11, 2017

if the type is free, we should use {?} meaning "Indicates that the variable can take on any type, and the compiler should not type-check any uses of it."

see https://github.com/google/closure-compiler/wiki/Type-Expressions#the-unknown-type

@fredj
Copy link
Member

fredj commented Oct 11, 2017

@pfirpfel According to @sbrunner ; the type should be Array.<Object>

@fredj
Copy link
Member

fredj commented Oct 11, 2017

@pfirpfel thanks, please merge

@pfirpfel pfirpfel merged commit 86ea59f into camptocamp:master Oct 11, 2017
@pfirpfel pfirpfel deleted the mapfish-print-ext branch October 20, 2017 07:03
@sbrunner sbrunner added this to the 2.3 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants