Preserve map_zoom setting when using search parameter #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Oct 18, 2017
fredj
reviewed
Oct 18, 2017
| @@ -959,7 +964,11 @@ gmf.SearchController.prototype.fulltextsearch_ = function(query, resultIndex) { | |||
| const format = new ol.format.GeoJSON(); | |||
| const feature = format.readFeature(data.features[resultIndex - 1]); | |||
| this.featureOverlay_.addFeature(feature); | |||
| this.map_.getView().fit(feature.getGeometry().getExtent()); | |||
| const fitOptions = /** @type {olx.view.FitOptions} */ ({}); | |||
| if (opt_zoom) { | |||
There was a problem hiding this comment.
Not sure that the zoom can be 0 but in the case the test will be false.
Should be changed to if (opt_zoom !== undefined) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fitting the map used to ignore the map_zoom parameter. This is annoying when dealing with small features as results. Those will set the map to an unreasonable high zoom level.
This change uses map_zoom as maximum zoom level when fitting the map to the search result.
To test the feature:
make build-gmf-apps examples-hosted-apps serveThen visit:
http://localhost:3000/.build/examples-hosted/contribs/gmf/apps/desktop_alt/?search=bettingen (defaults to map_zoom == 5 because of the feature size)
http://localhost:3000/.build/examples-hosted/contribs/gmf/apps/desktop_alt/?search=bettingen&map_zoom=3
The example data doesn't have very small features to search for, but this should show the functionality.